fix(bookmarks): Merge folders on move #164

Merged

bihe merged 4 commits from fix_folder_move into main

2025-06-22 15:41:07 +00:00

bihe commented

2025-06-22 14:07:58 +00:00

(Migrated from github.com)

if a folder is moved to a target location where the same folder exists, merge the contents of the folders.
this fix corrects the issue #160

if a folder is moved to a target location where the same folder exists, merge the contents of the folders. this fix corrects the issue #160

codecov-commenter commented

2025-06-22 14:10:44 +00:00

(Migrated from github.com)

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

❌ Patch coverage is 31.74603% with 129 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.79%. Comparing base (5f12bb0) to head (aa97efd).
⚠️ Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/bookmarks/app/bookmarks/bookmarks.go	58.41%	31 Missing and 11 partials ⚠️
pkg/handler/html/component_dialog_confirm.go	0.00%	39 Missing ⚠️
internal/bookmarks/web/templatesCRUD.go	2.85%	33 Missing and 1 partial ⚠️
internal/bookmarks/web/html/page_search.go	0.00%	13 Missing ⚠️
internal/bookmarks/router.go	0.00%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   47.13%   46.79%   -0.35%     
==========================================
  Files          80       80              
  Lines        6309     6496     +187     
==========================================
+ Hits         2974     3040      +66     
- Misses       3160     3271     +111     
- Partials      175      185      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

:warning: Please install the !['codecov app svg image'](https://github.com/codecov/engineering-team/assets/152432831/e90313f4-9d3a-4b63-8b54-cfe14e7ec20d) to ensure uploads and comments are reliably processed by Codecov. ## [Codecov](https://app.codecov.io/gh/bihe/monorepo/pull/164?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) Report :x: Patch coverage is `31.74603%` with `129 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.79%. Comparing base ([`5f12bb0`](https://app.codecov.io/gh/bihe/monorepo/commit/5f12bb0c8eff7b7f1dcbe6c5690663ea72523a01?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl)) to head ([`aa97efd`](https://app.codecov.io/gh/bihe/monorepo/commit/aa97efd6d0ccb653e02a416c112f0d844f4b7996?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl)). :warning: Report is 25 commits behind head on main. | [Files with missing lines](https://app.codecov.io/gh/bihe/monorepo/pull/164?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | Patch % | Lines | |---|---|---| | [internal/bookmarks/app/bookmarks/bookmarks.go](https://app.codecov.io/gh/bihe/monorepo/pull/164?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fapp%2Fbookmarks%2Fbookmarks.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL2FwcC9ib29rbWFya3MvYm9va21hcmtzLmdv) | 58.41% | [31 Missing and 11 partials :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [pkg/handler/html/component\_dialog\_confirm.go](https://app.codecov.io/gh/bihe/monorepo/pull/164?src=pr&el=tree&filepath=pkg%2Fhandler%2Fhtml%2Fcomponent_dialog_confirm.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-cGtnL2hhbmRsZXIvaHRtbC9jb21wb25lbnRfZGlhbG9nX2NvbmZpcm0uZ28=) | 0.00% | [39 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/web/templatesCRUD.go](https://app.codecov.io/gh/bihe/monorepo/pull/164?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fweb%2FtemplatesCRUD.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL3dlYi90ZW1wbGF0ZXNDUlVELmdv) | 2.85% | [33 Missing and 1 partial :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/web/html/page\_search.go](https://app.codecov.io/gh/bihe/monorepo/pull/164?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fweb%2Fhtml%2Fpage_search.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL3dlYi9odG1sL3BhZ2Vfc2VhcmNoLmdv) | 0.00% | [13 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/router.go](https://app.codecov.io/gh/bihe/monorepo/pull/164?src=pr&el=tree&filepath=internal%2Fbookmarks%2Frouter.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL3JvdXRlci5nbw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | :exclamation: Your organization needs to install the [Codecov GitHub app](https://github.com/apps/codecov/installations/select_target) to enable full functionality. <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## main #164 +/- ## ========================================== - Coverage 47.13% 46.79% -0.35% ========================================== Files 80 80 Lines 6309 6496 +187 ========================================== + Hits 2974 3040 +66 - Misses 3160 3271 +111 - Partials 175 185 +10 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/bihe/monorepo/pull/164?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>