henrik/monorepo
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

feat(bookmarks): Change the call to /toast #159 #162

Merged
bihe merged 1 commit from change_toast_issue159 into main 2025-06-21 16:46:56 +00:00
Conversation 1 Commits 1 Files changed 10 +46 -40
bihe commented 2025-06-21 16:43:33 +00:00 (Migrated from github.com)
Copy link

Use PUT to call the toast-notification.
Change the HTTP response to 204 (no content)

Use PUT to call the toast-notification. Change the HTTP response to 204 (no content)
codecov-commenter commented 2025-06-21 16:46:23 +00:00 (Migrated from github.com)
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 14.28571% with 30 lines in your changes missing coverage. Please review.

Project coverage is 47.13%. Comparing base (ea119eb) to head (d652a90).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/mydms/web/templateHandler.go 0.00% 9 Missing ⚠️
internal/bookmarks/web/templatesCRUD.go 0.00% 6 Missing ⚠️
internal/bookmarks/web/templatesFavicons.go 28.57% 5 Missing ⚠️
internal/bookmarks/web/templatesNotifications.go 0.00% 4 Missing ⚠️
internal/bookmarks/web/templateHandler.go 50.00% 3 Missing ⚠️
pkg/handler/html/toast.go 0.00% 2 Missing ⚠️
internal/bookmarks/router.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   47.16%   47.13%   -0.03%     
==========================================
  Files          80       80              
  Lines        6306     6309       +3     
==========================================
  Hits         2974     2974              
- Misses       3157     3160       +3     
  Partials      175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
:warning: Please install the !['codecov app svg image'](https://github.com/codecov/engineering-team/assets/152432831/e90313f4-9d3a-4b63-8b54-cfe14e7ec20d) to ensure uploads and comments are reliably processed by Codecov. ## [Codecov](https://app.codecov.io/gh/bihe/monorepo/pull/162?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) Report Attention: Patch coverage is `14.28571%` with `30 lines` in your changes missing coverage. Please review. > Project coverage is 47.13%. Comparing base [(`ea119eb`)](https://app.codecov.io/gh/bihe/monorepo/commit/ea119eb1cbf57db08426db5b94f382cdf1795576?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) to head [(`d652a90`)](https://app.codecov.io/gh/bihe/monorepo/commit/d652a906e7f7c6547babd24ec86b2ac5c0d0dff5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl). > Report is 1 commits behind head on main. | [Files with missing lines](https://app.codecov.io/gh/bihe/monorepo/pull/162?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | Patch % | Lines | |---|---|---| | [internal/mydms/web/templateHandler.go](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&filepath=internal%2Fmydms%2Fweb%2FtemplateHandler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvbXlkbXMvd2ViL3RlbXBsYXRlSGFuZGxlci5nbw==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/web/templatesCRUD.go](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fweb%2FtemplatesCRUD.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL3dlYi90ZW1wbGF0ZXNDUlVELmdv) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/web/templatesFavicons.go](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fweb%2FtemplatesFavicons.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL3dlYi90ZW1wbGF0ZXNGYXZpY29ucy5nbw==) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/web/templatesNotifications.go](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fweb%2FtemplatesNotifications.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL3dlYi90ZW1wbGF0ZXNOb3RpZmljYXRpb25zLmdv) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/web/templateHandler.go](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fweb%2FtemplateHandler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL3dlYi90ZW1wbGF0ZUhhbmRsZXIuZ28=) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [pkg/handler/html/toast.go](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&filepath=pkg%2Fhandler%2Fhtml%2Ftoast.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-cGtnL2hhbmRsZXIvaHRtbC90b2FzdC5nbw==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/router.go](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&filepath=internal%2Fbookmarks%2Frouter.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL3JvdXRlci5nbw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | :exclamation: Your organization needs to install the [Codecov GitHub app](https://github.com/apps/codecov/installations/select_target) to enable full functionality. <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## main #162 +/- ## ========================================== - Coverage 47.16% 47.13% -0.03% ========================================== Files 80 80 Lines 6306 6309 +3 ========================================== Hits 2974 2974 - Misses 3157 3160 +3 Partials 175 175 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/bihe/monorepo/pull/162?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Backend

   
Frontend

   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
Backend
Frontend
bug
dependencies
documentation
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
henrik/monorepo!162
No description provided.