chore: correct typos in comments and variables. #146

Merged

bihe merged 1 commit from typo_refactoring into main

2024-12-28 12:19:02 +00:00

bihe commented

2024-12-28 12:12:40 +00:00

(Migrated from github.com)

remove unused code and remove duplicates.

codecov-commenter commented

2024-12-28 12:15:36 +00:00

(Migrated from github.com)

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Attention: Patch coverage is 38.70968% with 57 lines in your changes missing coverage. Please review.

Project coverage is 60.15%. Comparing base (80f7d82) to head (bb05de9).

Files with missing lines	Patch %	Lines
pkg/develop/tokenhandler.go	7.27%	51 Missing ⚠️
internal/mydms/app/document/service.go	50.00%	2 Missing ⚠️
cmd/login/tokentest/main.go	0.00%	1 Missing ⚠️
internal/bookmarks/app/errors.go	66.66%	1 Missing ⚠️
...nternal/bookmarks/app/store/bookmark_repository.go	0.00%	1 Missing ⚠️
internal/bookmarks/server.go	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   59.83%   60.15%   +0.32%     
==========================================
  Files          75       75              
  Lines        6022     6016       -6     
==========================================
+ Hits         3603     3619      +16     
+ Misses       2225     2206      -19     
+ Partials      194      191       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

:warning: Please install the !['codecov app svg image'](https://github.com/codecov/engineering-team/assets/152432831/e90313f4-9d3a-4b63-8b54-cfe14e7ec20d) to ensure uploads and comments are reliably processed by Codecov. ## [Codecov](https://app.codecov.io/gh/bihe/monorepo/pull/146?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) Report Attention: Patch coverage is `38.70968%` with `57 lines` in your changes missing coverage. Please review. > Project coverage is 60.15%. Comparing base [(`80f7d82`)](https://app.codecov.io/gh/bihe/monorepo/commit/80f7d82205d62fa336ff77e6573b6d544bebe932?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) to head [(`bb05de9`)](https://app.codecov.io/gh/bihe/monorepo/commit/bb05de921c4751481552654682f0ac33b4264ca2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl). | [Files with missing lines](https://app.codecov.io/gh/bihe/monorepo/pull/146?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | Patch % | Lines | |---|---|---| | [pkg/develop/tokenhandler.go](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&filepath=pkg%2Fdevelop%2Ftokenhandler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-cGtnL2RldmVsb3AvdG9rZW5oYW5kbGVyLmdv) | 7.27% | [51 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/mydms/app/document/service.go](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&filepath=internal%2Fmydms%2Fapp%2Fdocument%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvbXlkbXMvYXBwL2RvY3VtZW50L3NlcnZpY2UuZ28=) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [cmd/login/tokentest/main.go](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&filepath=cmd%2Flogin%2Ftokentest%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-Y21kL2xvZ2luL3Rva2VudGVzdC9tYWluLmdv) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/app/errors.go](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fapp%2Ferrors.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL2FwcC9lcnJvcnMuZ28=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [...nternal/bookmarks/app/store/bookmark\_repository.go](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fapp%2Fstore%2Fbookmark_repository.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL2FwcC9zdG9yZS9ib29rbWFya19yZXBvc2l0b3J5Lmdv) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/server.go](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fserver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL3NlcnZlci5nbw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | :exclamation: Your organization needs to install the [Codecov GitHub app](https://github.com/apps/codecov/installations/select_target) to enable full functionality. <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## main #146 +/- ## ========================================== + Coverage 59.83% 60.15% +0.32% ========================================== Files 75 75 Lines 6022 6016 -6 ========================================== + Hits 3603 3619 +16 + Misses 2225 2206 -19 + Partials 194 191 -3 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/bihe/monorepo/pull/146?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl).