Cgoless sqlite #148

Merged

bihe merged 3 commits from cgoless_sqlite into main

2025-01-05 14:18:00 +00:00

bihe commented

2025-01-05 14:14:48 +00:00

(Migrated from github.com)

Try out a new golang sqlite variant which does not use CGO.
Replace https://github.com/mattn/go-sqlite3 with https://github.com/ncruces/go-sqlite3

Try out a new golang sqlite variant which does not use CGO. Replace https://github.com/mattn/go-sqlite3 with https://github.com/ncruces/go-sqlite3

codecov-commenter commented

2025-01-05 14:17:24 +00:00

(Migrated from github.com)

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Attention: Patch coverage is 61.64384% with 28 lines in your changes missing coverage. Please review.

Project coverage is 60.42%. Comparing base (d895b53) to head (4972d33).

Files with missing lines	Patch %	Lines
pkg/persistence/sqlite.go	74.50%	7 Missing and 6 partials ⚠️
internal/bookmarks/server.go	0.00%	6 Missing ⚠️
internal/core/server.go	0.00%	4 Missing ⚠️
internal/mydms/server.go	0.00%	4 Missing ⚠️
internal/mydms/app/shared/errors.go	50.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   60.14%   60.42%   +0.27%     
==========================================
  Files          75       74       -1     
  Lines        6025     6021       -4     
==========================================
+ Hits         3624     3638      +14     
+ Misses       2209     2184      -25     
- Partials      192      199       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

:warning: Please install the !['codecov app svg image'](https://github.com/codecov/engineering-team/assets/152432831/e90313f4-9d3a-4b63-8b54-cfe14e7ec20d) to ensure uploads and comments are reliably processed by Codecov. ## [Codecov](https://app.codecov.io/gh/bihe/monorepo/pull/148?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) Report Attention: Patch coverage is `61.64384%` with `28 lines` in your changes missing coverage. Please review. > Project coverage is 60.42%. Comparing base [(`d895b53`)](https://app.codecov.io/gh/bihe/monorepo/commit/d895b5330dcfb4508f9abecf92c806c2dfccad68?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) to head [(`4972d33`)](https://app.codecov.io/gh/bihe/monorepo/commit/4972d3345cd6a39e22cf53a1433119d60547bb17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl). | [Files with missing lines](https://app.codecov.io/gh/bihe/monorepo/pull/148?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | Patch % | Lines | |---|---|---| | [pkg/persistence/sqlite.go](https://app.codecov.io/gh/bihe/monorepo/pull/148?src=pr&el=tree&filepath=pkg%2Fpersistence%2Fsqlite.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-cGtnL3BlcnNpc3RlbmNlL3NxbGl0ZS5nbw==) | 74.50% | [7 Missing and 6 partials :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/bookmarks/server.go](https://app.codecov.io/gh/bihe/monorepo/pull/148?src=pr&el=tree&filepath=internal%2Fbookmarks%2Fserver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvYm9va21hcmtzL3NlcnZlci5nbw==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/core/server.go](https://app.codecov.io/gh/bihe/monorepo/pull/148?src=pr&el=tree&filepath=internal%2Fcore%2Fserver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvY29yZS9zZXJ2ZXIuZ28=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/mydms/server.go](https://app.codecov.io/gh/bihe/monorepo/pull/148?src=pr&el=tree&filepath=internal%2Fmydms%2Fserver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvbXlkbXMvc2VydmVyLmdv) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | | [internal/mydms/app/shared/errors.go](https://app.codecov.io/gh/bihe/monorepo/pull/148?src=pr&el=tree&filepath=internal%2Fmydms%2Fapp%2Fshared%2Ferrors.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl#diff-aW50ZXJuYWwvbXlkbXMvYXBwL3NoYXJlZC9lcnJvcnMuZ28=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/bihe/monorepo/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl) | :exclamation: Your organization needs to install the [Codecov GitHub app](https://github.com/apps/codecov/installations/select_target) to enable full functionality. <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## main #148 +/- ## ========================================== + Coverage 60.14% 60.42% +0.27% ========================================== Files 75 74 -1 Lines 6025 6021 -4 ========================================== + Hits 3624 3638 +14 + Misses 2209 2184 -25 - Partials 192 199 +7 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/bihe/monorepo/pull/148?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Henrik+Binggl).